SAP EVALUATION - Guide

Get Example source ABAP code based on a different SAP table
  SAP Help

Evaluation of System Fields

ABAP_BACKGROUND
System fields describe general system states or are set specifically by individual statements. The content of system fields is only defined as described in the documentation of the system fields or in the documentation of ABAP statements that set system fields. In contexts other than those described there, the content of system fields is not defined. Particularly statements whose effects on system fields are undocumented can modify the content of specific system fields, such as the return code sy-subrc, in an undefined way. This applies especially to statements that call ABAP code implicitly or explicitly when executed.

ABAP_RULE
Evaluate system fields in the right position
Evaluate system fields only in contexts for which they are defined. If an ABAP statement sets a system field in accordance with its documentation, the field should be evaluated directly after the statement. You must not evaluate system fields after statements, however, whose effects are undocumented.

ABAP_DETAILS
If possible, a system field should be evaluated directly after the statement that set it, to prevent it from being overwritten by other statements. The bigger the gap between the ABAP statement in question and the evaluation of a system field, the higher the risk that this system field will be affected by a different statement in the meantime.
If necessary, the values of system fields should be saved in helper variables. This applies in particular to the general return code, sy-subrc, which is set by very many different statements. Other common examples include the syindex loop counter or the sy-tabix table index.
You should never evaluate statement-related system fields after statements that do not set these fields according to their documentation. As before, a common example is the evaluation of sy-subrc. If it is not documented for a statement that it sets sy-subrc in a defined way, an evaluation after this statement is very risky. Either sy-subrc still has the previous value, or it is set in an undefined way by the statement. Both outcomes can lead to incorrect program behavior. The bad example in the extended program check section shows an example of this.



Latest notes:
The static methods of the class CL_ABAP_SYST also provide important system states. There is no possibility of a previous overwriting in the program.
ABAP_HINT_END

ABAP_EXAMPLE_BAD
The following source code shows an example where sy-subrc is evaluated too late. Even if it is not documented for the statements between FIND and IF that they set sy-subrc, the value can be overwritten due to possible side effects. FIND PCRE ... IN ...
...
... 'other statements
...
IF sy-subrc = 0.
...
ENDIF.
ABAP_EXAMPLE_END

ABAP_EXAMPLE_GOOD
The following source code corrects the above example by assigning sy-subrc to a helper variable directly after FIND. This variable is then evaluated in IF. It can also be necessary to assign sy-index or sy-tabix to a helper variable directly after DO or LOOP loop is entered. FIND PCRE ... IN ...
find_subrc = sy-subrc.
...
... 'other statements
...
IF find_subrc = 0.
...
ENDIF.
ABAP_EXAMPLE_END